cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Lohfink (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-11966) When SEPWorker assigned work, set thread name to match pool
Date Wed, 08 Jun 2016 03:34:21 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319920#comment-15319920
] 

Chris Lohfink edited comment on CASSANDRA-11966 at 6/8/16 3:33 AM:
-------------------------------------------------------------------

An example before/after with patch:


Before:
{code}
 activity 
--...-------------------------------------------------------------+-
  ...                                          Execute CQL3 query | 
  ...   Parsing select * from system.peers; [SharedPool-Worker-1] | 
  ...                   Preparing statement [SharedPool-Worker-1] | 
  ...             Computing ranges to query [SharedPool-Worker-1] | 
  ...y of 1 (403.2 rows per range expected) [SharedPool-Worker-1] | 
  ... Submitted 1 concurrent range requests [SharedPool-Worker-1] | 
  ...854775808), min(-9223372036854775808)) [SharedPool-Worker-2] | 
  ...     Read 1 live and 0 tombstone cells [SharedPool-Worker-2] | 
  ...
  ...                                            Request complete | 
                                                                                         
            
                                                                                         
            {code}

After:
{code}
 activity                                          
-----...------------------------------------------------------------------------+-
     ...                                                     Execute CQL3 query |
     ...      Parsing select * from system.peers; [Native-Transport-Requests-2] |
     ...                      Preparing statement [Native-Transport-Requests-2] |
     ...                Computing ranges to query [Native-Transport-Requests-2] 
 Subm...ency of 1 (604.8 rows per range expected) [Native-Transport-Requests-2] |
     ...    Submitted 1 concurrent range requests [Native-Transport-Requests-2] |
     ...or (min(-9223372036854775808), min(-9223372036854775808)) [ReadStage-1] |
     ...                        Read 1 live and 0 tombstone cells [ReadStage-1] |
     ...                                                       Request complete |
{code}




was (Author: cnlwsu):
An example before/after with patch:


Before:
{code}
 activity                                                                                
                             | 
--...-------------------------------------------------------------+-
  ...                                          Execute CQL3 query | 
  ...   Parsing select * from system.peers; [SharedPool-Worker-1] | 
  ...                   Preparing statement [SharedPool-Worker-1] | 
  ...             Computing ranges to query [SharedPool-Worker-1] | 
  ...y of 1 (403.2 rows per range expected) [SharedPool-Worker-1] | 
  ... Submitted 1 concurrent range requests [SharedPool-Worker-1] | 
  ...854775808), min(-9223372036854775808)) [SharedPool-Worker-2] | 
  ...     Read 1 live and 0 tombstone cells [SharedPool-Worker-2] | 
  ...
  ...                                            Request complete | 
                                                                                         
            
                                                                                         
            {code}

After:
{code}
 activity                                          
-----...------------------------------------------------------------------------+-
     ...                                                     Execute CQL3 query |
     ...      Parsing select * from system.peers; [Native-Transport-Requests-2] |
     ...                      Preparing statement [Native-Transport-Requests-2] |
     ...                   Computing ranges to query [Native-Transport-Requests-2] 
 Subm...ency of 1 (604.8 rows per range expected) [Native-Transport-Requests-2] |
     ...    Submitted 1 concurrent range requests [Native-Transport-Requests-2] |
     ...or (min(-9223372036854775808), min(-9223372036854775808)) [ReadStage-1] |
     ...                        Read 1 live and 0 tombstone cells [ReadStage-1] |
     ...                                                       Request complete |
{code}



> When SEPWorker assigned work, set thread name to match pool
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-11966
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11966
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability
>            Reporter: Chris Lohfink
>            Assignee: Chris Lohfink
>            Priority: Minor
>
> Currently in traces, logs, and stacktraces you cant really associate the thread name
with the pool since its just "SharedWorker-#". Calling setName around the task could improve
logging and tracing a little while being a cheap operation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message