cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-11948) Wrong ByteBuffer comparisons in TimeTypeTest
Date Fri, 17 Jun 2016 16:53:05 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-11948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joshua McKenzie updated CASSANDRA-11948:
----------------------------------------
       Resolution: Fixed
    Fix Version/s:     (was: 3.0.x)
                       (was: 2.2.x)
                       (was: 3.x)
                   3.0.8
                   3.8
                   2.2.7
           Status: Resolved  (was: Ready to Commit)

[Committed|https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=fd91e1593941d39c536d28542af539e5009be0d4]
and merged up.

Having written those original tests, the break from the "-1, 0, 1" idiom on comparison is
quite the surprise to me. Good catch!

> Wrong ByteBuffer comparisons in TimeTypeTest
> --------------------------------------------
>
>                 Key: CASSANDRA-11948
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11948
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Testing
>            Reporter: Rei Odaira
>            Assignee: Rei Odaira
>            Priority: Minor
>             Fix For: 2.2.7, 3.8, 3.0.8
>
>         Attachments: 11948-2.2.txt
>
>
> The last three tests in org.apache.cassandra.db.marshal.TimeTypeTest compare the returned
values of AbstractType.compare() with -1 or 1. However,  AbstractType.compare() is supposed
to return a negative integer, zero, or a positive integer, and it does not necessarily return
-1 or 1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message