cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11841) Add keep-alive to stream protocol
Date Tue, 07 Jun 2016 16:54:21 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15318862#comment-15318862
] 

Yuki Morishita commented on CASSANDRA-11841:
--------------------------------------------

Thanks for the patch. Overall it seems good.
One thing to point out is I thing we should {{setRemoveOnCancelPolicy(true)}} on {{keepAliveExecutor}}
otherwise the task may send keep alive to already closed connection.

Can you run tests again, since it seems they were not running properly?

> Add keep-alive to stream protocol
> ---------------------------------
>
>                 Key: CASSANDRA-11841
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11841
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Paulo Motta
>            Assignee: Paulo Motta
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message