cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11580) remove DatabaseDescriptor dependency from SegmentedFile
Date Tue, 07 Jun 2016 03:20:21 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15317744#comment-15317744
] 

Yuki Morishita commented on CASSANDRA-11580:
--------------------------------------------

I ended up renaming {{SegmentedFile}} to {{FileHandle}}. If anyone has better name, I'm open
to suggestion.
I think I fixed he points in the review, except: The EMPTY BufferHolder in Rebuffered.java
at line 62 can still be static final. variable in interface is implicitly declared as public
static final, and my IntelliJ gives me warning if I left those.

||branch||testall||dtest||
|[11580|https://github.com/yukim/cassandra/tree/11580]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11580-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11580-dtest/lastCompletedBuild/testReport/]|


> remove DatabaseDescriptor dependency from SegmentedFile
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11580
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>             Fix For: 3.x
>
>
> Several configurable parameters are pulled from {{DatabaseDescriptor}} from {{SegmentedFile}}
and its subclasses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message