cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11580) remove DatabaseDescriptor dependency from SegmentedFile
Date Fri, 17 Jun 2016 11:08:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335873#comment-15335873
] 

Stefania commented on CASSANDRA-11580:
--------------------------------------

I've pushed some nits [here|https://github.com/stef1927/cassandra/commit/ddee27868592076c7c30c285eb92938450eafe9e]:
mostly edits in the comments, unused imports and more restrictive access modifiers in RAR.
I've also fixed some resource management problems in unit tests, and in the two new {{open()}}
methods in case of exceptions. I've rebased, which resulted in a couple of conflicts, especially
in {{CommitLogReader}} where some code has been moved around. 

If you're +1 on my changes and the CI results are OK, then I'm also + 1 and we can commit
this:

|[patch|https://github.com/stef1927/cassandra/commits/11580]|[testall|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11580-testall/]|[dtest|http://cassci.datastax.com/view/Dev/view/stef1927/job/stef1927-11580-dtest/]|

In terms of a better name for {{FileHandle}}, I'm also short of suggestions, it is a factory
for RAR basically, but one that owns resources, so the term {{Handle}} is probably as good
as {{Factory}} and given that it is created by a builder, I tend to think that {{FileHandle}}
is probably better then something with the term factory in it. Feel free to start a discussion
on IIRC re. a better name if you want, once you are back from holiday, or commit with {{FileHandle}}.


> remove DatabaseDescriptor dependency from SegmentedFile
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11580
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11580
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>             Fix For: 3.x
>
>
> Several configurable parameters are pulled from {{DatabaseDescriptor}} from {{SegmentedFile}}
and its subclasses.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message