cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-10202) simplify CommitLogSegmentManager
Date Tue, 14 Jun 2016 19:14:27 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-10202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330204#comment-15330204
] 

Joshua McKenzie commented on CASSANDRA-10202:
---------------------------------------------

I'm -1 on us including our own implementation of a concurrent linked list unless we can strongly
justify the inclusion of that complexity. We have to maintain this code and frankly, I find
this container even more unnecessarily complex to reason about than our current {{CommitLogSegmentManager.advanceAllocatingFrom}}
which is saying something.

This reminds me a lot of CASSANDRA-7282 where we're taking out a battle-tested concurrent
collection in favor of writing our own from scratch. I was hesitant about us doing that then
and I remain so now.

> simplify CommitLogSegmentManager
> --------------------------------
>
>                 Key: CASSANDRA-10202
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-10202
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local Write-Read Paths
>            Reporter: Jonathan Ellis
>            Assignee: Branimir Lambov
>            Priority: Minor
>
> Now that we only keep one active segment around we can simplify this from the old recycling
design.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message