cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9039) CommitLog compressed configuration not run in several unit tests
Date Thu, 02 Jun 2016 08:23:59 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311930#comment-15311930
] 

Benjamin Lerer commented on CASSANDRA-9039:
-------------------------------------------

{quote}
We should also test compressed + encrypted combinations; there are some buffer type switches
and code branches that are triggered depending on compressor's preferred buffer type, so we
should do that for all compressor types.
{quote}

I looked at the code and got a bit confused. If my understanding is right the choice of creating
an encrypted or compressed segment is made in {{CommitLogSegment::createSegment}}. Basicaly,
if encryption is enabled the segment will be encrypted (and compressed under the hood using
LZ4) and the compression settings will be ignored.
In the case where encryption is disabled, the encryption setting will still be loaded to allow
reading previously encrypted commit log segment.

I found that from the user perspective it migth be good to either reject or issue a warning
in the case where the compression are ignored because encryption is enabled. What do you think
[~barnie], [~jasobrown]? 

[~barnie] My understanding is that you want me to add test for: encryption enabled + all types
of compressions, am I right?

 

> CommitLog compressed configuration not run in several unit tests
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-9039
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9039
>             Project: Cassandra
>          Issue Type: Test
>          Components: Local Write-Read Paths
>            Reporter: Ariel Weisberg
>            Assignee: Benjamin Lerer
>             Fix For: 2.2.x, 3.0.x, 3.x
>
>
> CommitLogTest, RecoveryManagerTest, RecoveryManagerTruncateTest, RecoveryManager2Test,
RecoveryManager3Test
> Some or all of these should be run with a commit log configured to use compression.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message