cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-7190) Add schema to snapshot manifest
Date Thu, 02 Jun 2016 11:46:59 GMT


Alex Petrov updated CASSANDRA-7190:
    Status: Patch Available  (was: Open)

Thank you for the review. 

I've found a couple of "edge cases" in generation that have affected the implementation: create
a column with a UDT, drop column and then drop UDT, type referenced in the {{DroppedColumn}}
is now just a tuple type. That was also the reason to not include types of dropped columns
together with the other {{CREATE TYPE}} statements. Also, re-adding static columns. During
{{ALTER TABLE ADD}}, it's important to use the non-dropped definition. 

Things like dropping type that's present in dropped column is also covered with tests. 

I've added a file called {{schema.cql}} that contains all re-create schema information, all
consolidated in a single file. It starts with creating types, followed by the table creation,
then dropped columns (with re-creation, where column first created in {{CREATE TABLE}} statement,
then dropped with a timestamp and then re-added back), and finally followed by indexes, as
they require a full schema. 

Also, the test with drop/re-add static column is added to make sure behaviour is as desired.


> Add schema to snapshot manifest
> -------------------------------
>                 Key: CASSANDRA-7190
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: Alex Petrov
>            Priority: Minor
>              Labels: client-impacting, doc-impacting, lhf
>             Fix For: 3.0.x, 3.x
> followup from CASSANDRA-6326

This message was sent by Atlassian JIRA

View raw message