Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 18 May 2016 16:39:13 +0000 (UTC)
From: "Jonathan Ellis (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12970822.1463589107000.225332.1463589553089@Atlassian.JIRA>
In-Reply-To: <JIRA.12970822.1463589107000@Atlassian.JIRA>
References: <JIRA.12970822.1463589107000@Atlassian.JIRA> <JIRA.12970822.1463589107938@arcas>
Subject: [jira] [Updated] (CASSANDRA-11834) Don't compute expensive
 MaxPurgeableTimestamp until we've verified there's an expired tombstone
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 May 2016 16:39:15 -0000


     [ https://issues.apache.org/jira/browse/CASSANDRA-11834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-11834:
---------------------------------------
    Attachment: 11834.txt

Trivial patch attached.

> Don't compute expensive MaxPurgeableTimestamp until we've verified there's an expired tombstone
> -----------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11834
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11834
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Jonathan Ellis
>             Fix For: 2.1.15
>
>         Attachments: 11834.txt
>
>
> In LCR's get reduced, we currently do this:
> {code}
>                 if (t.timestamp() < getMaxPurgeableTimestamp() && t.data.isGcAble(controller.gcBefore))
> {code}
> Should call the expensive getMaxPurgeableTimestamp only after we have called the cheap isGcAble.
> Marking this as a bug since it can cause pathological performance problems (CASSANDRA-11831).
> Have verified that this is not a problem in 3.0 (CompactionIterator does the check in the correct order).


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)