Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 604F12007D0 for ; Tue, 10 May 2016 18:10:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5E3FA160A11; Tue, 10 May 2016 16:10:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C9B1A160877 for ; Tue, 10 May 2016 18:10:13 +0200 (CEST) Received: (qmail 78101 invoked by uid 500); 10 May 2016 16:10:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 78077 invoked by uid 99); 10 May 2016 16:10:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 16:10:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D2A102C14F8 for ; Tue, 10 May 2016 16:10:12 +0000 (UTC) Date: Tue, 10 May 2016 16:10:12 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11705) clearSnapshots using Directories.dataDirectories instead of CFS.initialDirectories MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 10 May 2016 16:10:14 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278363#comment-15278363 ] Aleksey Yeschenko commented on CASSANDRA-11705: ----------------------------------------------- Every time you add an unnecessary {{syncrhonized}} declaration, it makes someone like me scratch my head and waste my time on trying to understand why it's there. Should just grab the reference. Also, JDK has {{Arrays.copyOf()}} so that you wouldn't need to reinvent copying logic itself (: > clearSnapshots using Directories.dataDirectories instead of CFS.initialDirectories > ---------------------------------------------------------------------------------- > > Key: CASSANDRA-11705 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11705 > Project: Cassandra > Issue Type: Bug > Reporter: Blake Eggleston > Assignee: Blake Eggleston > Priority: Minor > Fix For: 3.0.x, 3.x > > > An oversight in CASSANDRA-10518 prevents snapshots created in data directories defined outside of cassandra.yaml from being cleared by {{Keyspace.clearSnapshots}}. {{ColumnFamilyStore.initialDirectories}} should be used when finding snapshots to clear, not {{Directories.dataDirectories}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)