Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5E39A2009A0 for ; Tue, 3 May 2016 13:58:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5D3AF1609F7; Tue, 3 May 2016 13:58:14 +0200 (CEST) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CC7401609F3 for ; Tue, 3 May 2016 13:58:13 +0200 (CEST) Received: (qmail 50460 invoked by uid 500); 3 May 2016 11:58:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 50424 invoked by uid 99); 3 May 2016 11:58:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 May 2016 11:58:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D7F0A2C14F9 for ; Tue, 3 May 2016 11:58:12 +0000 (UTC) Date: Tue, 3 May 2016 11:58:12 +0000 (UTC) From: "Aleksey Yeschenko (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11647) Don't use static dataDirectories field in Directories instances MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 03 May 2016 11:58:14 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-11647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268579#comment-15268579 ] Aleksey Yeschenko commented on CASSANDRA-11647: ----------------------------------------------- Are you sure that this is sufficient? - there is another use of {{dataDirectories}} in {{getKSChildDirectories()}} - there are cases of instantiation of {{Directories}} with {{Directories.dataDirectories}} in {{AbstractCompactionStrategy}} constructor, and in {{ColumnFamilyStore}} 's {{createColumnFamilyStore()}} and {{getDirectories()}} methods The latter might not be an issue, but skipping on the former seems like a potential issue to me. > Don't use static dataDirectories field in Directories instances > --------------------------------------------------------------- > > Key: CASSANDRA-11647 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11647 > Project: Cassandra > Issue Type: Improvement > Reporter: Blake Eggleston > Assignee: Blake Eggleston > Fix For: 3.6 > > > Some of the changes to Directories by CASSANDRA-6696 use the static {{dataDirectories}} field, instead of the instance field {{paths}}. This complicates things for external code creating their own Directories instances. -- This message was sent by Atlassian JIRA (v6.3.4#6332)