Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 2 May 2016 15:13:13 +0000 (UTC)
From: "Edward Capriolo (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12957248.1460131444000.86188.1462201993031@Atlassian.JIRA>
In-Reply-To: <JIRA.12957248.1460131444000@Atlassian.JIRA>
References: <JIRA.12957248.1460131444000@Atlassian.JIRA> <JIRA.12957248.1460131444115@arcas>
Subject: [jira] [Commented] (CASSANDRA-11537) Give clear error when certain
 nodetool commands are issued before server is ready
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 02 May 2016 15:13:15 -0000


    [ https://issues.apache.org/jira/browse/CASSANDRA-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15266761#comment-15266761 ] 

Edward Capriolo commented on CASSANDRA-11537:
---------------------------------------------

[~snazy] The document: http://wiki.apache.org/cassandra/HowToContribute suggest:
You'll want to checkout out the branch corresponding to the lowest version in which you want to introduce the change. 

Does this documentation require update?


> Give clear error when certain nodetool commands are issued before server is ready
> ---------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11537
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11537
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>              Labels: lhf
>
> As an ops person upgrading and servicing Cassandra servers, I require a more clear message when I issue a nodetool command that the server is not ready for it so that I am not confused.
> Technical description:
> If you deploy a new binary, restart, and issue nodetool scrub/compact/updatess etc you get unfriendly assertion. An exception would be easier to understand. Also if a user has turned assertions off it is unclear what might happen. 
> {noformat}
> EC1: Throw exception to make it clear server is still in start up process. 
> :~# nodetool upgradesstables
> error: null
> -- StackTrace --
> java.lang.AssertionError
>     at org.apache.cassandra.db.Keyspace.open(Keyspace.java:97)
>     at org.apache.cassandra.service.StorageService.getValidKeyspace(StorageService.java:2573)
>     at org.apache.cassandra.service.StorageService.getValidColumnFamilies(StorageService.java:2661)
>     at org.apache.cassandra.service.StorageService.upgradeSSTables(StorageService.java:2421)
> {noformat}
> EC1: 
> Patch against 2.1 (branch)
> https://github.com/apache/cassandra/compare/trunk...edwardcapriolo:exception-on-startup?expand=1


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)