Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A06D7200A5B for ; Wed, 25 May 2016 21:40:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9F389160A0F; Wed, 25 May 2016 19:40:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E708D160A29 for ; Wed, 25 May 2016 21:40:39 +0200 (CEST) Received: (qmail 30748 invoked by uid 500); 25 May 2016 19:24:21 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 30038 invoked by uid 99); 25 May 2016 19:19:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 May 2016 19:19:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id F00252C1F6D for ; Wed, 25 May 2016 19:19:12 +0000 (UTC) Date: Wed, 25 May 2016 19:19:12 +0000 (UTC) From: "Paulo Motta (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-10862) LCS repair: compact tables before making available in L0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 25 May 2016 19:40:40 -0000 [ https://issues.apache.org/jira/browse/CASSANDRA-10862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300686#comment-15300686 ] Paulo Motta commented on CASSANDRA-10862: ----------------------------------------- Is this incremental or non-incremental repair? What version? Do you know if these 4000 sstables were created from streaming alone or from anti-compaction? CASSANDRA-6851 reduced the amount of sstables generated after anti-compaction, so maybe that will already help mitigate this. If the problem is with streaming, we could perhaps add a configurable threshold and perform STCS on received sstables before adding them to the datatracker ({{OnCompletionRunnable}}). We should probably disable this during bootstrap, as people generally want their nodes to bootstrap faster. We should also make sure the sstables are not added to the data-tracker when they are compacted, but only after all of them are compacted in order to be able to abort/rollback the transaction if the node fails before that. > LCS repair: compact tables before making available in L0 > -------------------------------------------------------- > > Key: CASSANDRA-10862 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10862 > Project: Cassandra > Issue Type: Improvement > Components: Compaction, Streaming and Messaging > Reporter: Jeff Ferland > > When doing repair on a system with lots of mismatched ranges, the number of tables in L0 goes up dramatically, as correspondingly goes the number of tables referenced for a query. Latency increases dramatically in tandem. > Eventually all the copied tables are compacted down in L0, then copied into L1 (which may be a very large copy), finally reducing the number of SSTables per query into the manageable range. > It seems to me that the cleanest answer is to compact after streaming, then mark tables available rather than marking available when the file itself is complete. -- This message was sent by Atlassian JIRA (v6.3.4#6332)