cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11912) Remove DatabaseDescriptor import from AbstractType
Date Tue, 31 May 2016 05:45:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307238#comment-15307238
] 

Stefania commented on CASSANDRA-11912:
--------------------------------------

Thanks for confirming that the overload is enough.

[~ifesdjeen]: there is a [problem|https://cassci.datastax.com/view/Dev/view/ifesdjeen/job/ifesdjeen-11912-trunk-testall/lastCompletedBuild/testReport/junit.framework/TestSuite/org_apache_cassandra_db_compaction_BlacklistingCompactionsTest/]
with {{BlacklistingCompactionsTest}}, [{{teadDown}}|https://github.com/ifesdjeen/cassandra/commit/a1e7cdb2a503c838001f278315f5830c3c5cee94#diff-56d0c56936f743e24c7eca7b3f142e51R87]
is incorrectly marked as {{@BeforeClass}} rather than {{@AfterClass}}. Also, the dtests on
trunk have not run yet. 

The rest of the patch looks OK. 

> Remove DatabaseDescriptor import from AbstractType
> --------------------------------------------------
>
>                 Key: CASSANDRA-11912
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11912
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Configuration, Core
>            Reporter: Jeremiah Jordan
>            Assignee: Alex Petrov
>             Fix For: 3.0.x, 3.x
>
>
> CASSANDRA-9530 added an import of DatabaseDescriptor in AbstractType, this import breaks
Thrift based java code which uses AbstractType based classes to deserialize types.  The max
size value should be give to AbstractType in some other way that doesn't require importing
DatabaseDescriptor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message