cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-11868) unused imports and generic types
Date Mon, 23 May 2016 19:14:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296896#comment-15296896
] 

Edward Capriolo edited comment on CASSANDRA-11868 at 5/23/16 7:13 PM:
----------------------------------------------------------------------

The case statements look like this:

{noformat}
switch (enum) {
  case YES:
  do yes stuff
  break
  case NO:
  do no stuff
  break;
}
throw IllegalArgumentException("Thie compiler would rather have me in the default")
{noformat}


was (Author: appodictic):
The case statements look like this:

{noformat}
switch (enum) {
  case YES:
  do yes stuff
  break
  case NO
  do no stuff
  beak
}
throw IllegalArgumentException("Thie compiler would rather have me in the default")
{noformat}

> unused imports and generic types
> --------------------------------
>
>                 Key: CASSANDRA-11868
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11868
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>
> I was going through Cassandra source and for busy work I started looking at all the .java
files eclipse flags as warning. They are broken roughly into a few cases. 
> 1) unused imports 
> 2) raw types missing <> 
> 3) case statements without defaults 
> 4) @resource annotation 
> My IDE claims item 4 is not needed (it looks like we have done this to signify methods
that return objects that need to be closed) I can guess 4 was done intentionally and short
of making out own annotation I will ignore these for now. 
> I would like to tackle this busy work before I get started. I have some questions: 
> 1) Do this only on trunk? or multiple branches 
> 2) should I tackle 1,2,3 in separate branches/patches



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message