cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11848) replace address can "succeed" without actually streaming anything
Date Wed, 25 May 2016 00:06:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299195#comment-15299195
] 

Paulo Motta commented on CASSANDRA-11848:
-----------------------------------------

Tests look good now*, this is ready for review.

*1 Please ignore failure of {{bootstrap_test.TestBootstrap.simple_bootstrap_test_small_streaming_socket_timeout_in_ms}}
which is a new test from another branch that I included in the commit by mistake (already
remove from dtest branch).
*2 {{bootstrap_test.TestBootstrap.resumable_bootstrap_test}} failed on 3.0 and trunk, but
it seems it's due to CASSANDRA-11414. I tested locally and works. Resubmitted just in case.

> replace address can "succeed" without actually streaming anything
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-11848
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11848
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Streaming and Messaging
>            Reporter: Jeremiah Jordan
>            Assignee: Paulo Motta
>             Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
>
>
> When you do a replace address and the new node has the same IP as the node it is replacing,
then the following check can let the replace be successful even if we think all the other
nodes are down: https://github.com/apache/cassandra/blob/cassandra-2.1/src/java/org/apache/cassandra/dht/RangeStreamer.java#L271
> As the FailureDetectorSourceFilter will exclude the other nodes, so an empty stream plan
gets executed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message