cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Lerer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11718) entry-weighers in QueryProcessor should respect partitionKeyBindIndexes field
Date Mon, 23 May 2016 13:30:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15296359#comment-15296359
] 

Benjamin Lerer commented on CASSANDRA-11718:
--------------------------------------------

I think that I would have keep the {{measure}} method as it was but added a {{measureCacheEntry(Object,
ParsedStatement.Prepared)}} method similar to the one that you added.

It seems to me that:
{code}
ObjectSizes.measureDeep(value.rawCQLStatement) +
ObjectSizes.measureDeep(value.statement) +
ObjectSizes.measureDeep(value.boundNames) +
(value.partitionKeyBindIndexes != null ? ObjectSizes.measureDeep(value.partitionKeyBindIndexes)
: 0));
{code}
could simply be replaced by:
{code}
ObjectSizes.measureDeep(value) ;
{code}
The advantage being also that if new fields are added to {{ParsedStatement.Prepared}} they
wil be automatically taken into account.

I also noticed that the {{meter}} field is not used anymore but has not been removed. Could
you also remove it?




> entry-weighers in QueryProcessor should respect partitionKeyBindIndexes field
> -----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11718
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11718
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.x
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message