cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11705) clearSnapshots using Directories.dataDirectories instead of CFS.initialDirectories
Date Tue, 10 May 2016 16:10:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15278363#comment-15278363
] 

Aleksey Yeschenko commented on CASSANDRA-11705:
-----------------------------------------------

Every time you add an unnecessary {{syncrhonized}} declaration, it makes someone like me scratch
my head and waste my time on trying to understand why it's there. Should just grab the reference.
Also, JDK has {{Arrays.copyOf()}} so that you wouldn't need to reinvent copying logic itself
(:

> clearSnapshots using Directories.dataDirectories instead of CFS.initialDirectories
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11705
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11705
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>            Priority: Minor
>             Fix For: 3.0.x, 3.x
>
>
> An oversight in CASSANDRA-10518 prevents snapshots created in data directories defined
outside of cassandra.yaml from being cleared by {{Keyspace.clearSnapshots}}. {{ColumnFamilyStore.initialDirectories}}
should be used when finding snapshots to clear, not {{Directories.dataDirectories}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message