cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11647) Don't use static dataDirectories field in Directories instances
Date Tue, 03 May 2016 11:58:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15268579#comment-15268579
] 

Aleksey Yeschenko commented on CASSANDRA-11647:
-----------------------------------------------

Are you sure that this is sufficient?
- there is another use of {{dataDirectories}} in {{getKSChildDirectories()}}
- there are cases of instantiation of {{Directories}} with {{Directories.dataDirectories}}
in {{AbstractCompactionStrategy}} constructor, and in {{ColumnFamilyStore}} 's {{createColumnFamilyStore()}}
and {{getDirectories()}} methods

The latter might not be an issue, but skipping on the former seems like a potential issue
to me.

> Don't use static dataDirectories field in Directories instances
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-11647
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11647
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Blake Eggleston
>            Assignee: Blake Eggleston
>             Fix For: 3.6
>
>
> Some of the changes to Directories by CASSANDRA-6696 use the static {{dataDirectories}}
field, instead of the instance field {{paths}}. This complicates things for external code
creating their own Directories instances.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message