cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-9530) SSTable corruption can trigger OOM
Date Wed, 11 May 2016 09:26:12 GMT


Sylvain Lebresne commented on CASSANDRA-9530:

bq. Do you think it'd be still useful to only test for cases without compression?

Yes, I think that's useful since we don't do block checksums in that case, and we believe
no compression is a much more viable option in 3.0.

> SSTable corruption can trigger OOM
> ----------------------------------
>                 Key: CASSANDRA-9530
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Sylvain Lebresne
> If a sstable is corrupted so that the length of a given is bogus, we'll still happily
try to allocate a buffer of that bogus size to read the value, which can easily lead to an
> We should probably protect against this. In practice, a given value can be so big since
it's limited by the protocol frame size in the first place. Maybe we could add a max_value_size_in_mb
setting and we'd considered a sstable corrupted if it was containing a value bigger than that.
> I'll note that this ticket would be a good occasion to improve {{BlacklistingCompactionsTest}}.
Typically, it currently generate empty values which makes it pretty much impossible to get
the problem described here. And as described in CASSANDRA-9478, it also doesn't test properly
for thing like early opening of compaction results. We could try to randomize as much of the
parameters of this test as possible to make it more likely to catch any type of corruption
that could happen.

This message was sent by Atlassian JIRA

View raw message