cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Shuler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8092) Check for swallowed Throwable in CI environment
Date Tue, 17 May 2016 18:32:13 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15287216#comment-15287216
] 

Michael Shuler commented on CASSANDRA-8092:
-------------------------------------------

I'm all for someone committing this utility and we can set up CI to run it.

> Check for swallowed Throwable in CI environment
> -----------------------------------------------
>
>                 Key: CASSANDRA-8092
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8092
>             Project: Cassandra
>          Issue Type: Test
>            Reporter: Joshua McKenzie
>            Assignee: Michael Shuler
>            Priority: Minor
>             Fix For: 2.1.x
>
>         Attachments: 7507_check_swallowed.txt
>
>
> Reference CASSANDRA-7507.  We don't want to swallow Throwable or Exception's in the code-base
but rather delegate them to the JVMStabilityInspector added in that ticket.  Attached patch
adds a python script to tools\bin (maybe incorrect placement) that'll check for Throwable
and return count of swallowed.  It will also do the same for Exception if you pass it the
flag for that.
> Ideally we'd integrate checking our code-base on build in the CI environment and fail
if we have count > 0 on Throwable for now, and update it to include Exception as well after
CASSANDRA-7579.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message