Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AD168190C7 for ; Tue, 26 Apr 2016 11:26:13 +0000 (UTC) Received: (qmail 16510 invoked by uid 500); 26 Apr 2016 11:26:13 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 16136 invoked by uid 500); 26 Apr 2016 11:26:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 15993 invoked by uid 99); 26 Apr 2016 11:26:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Apr 2016 11:26:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CDFF82C1F5D for ; Tue, 26 Apr 2016 11:26:12 +0000 (UTC) Date: Tue, 26 Apr 2016 11:26:12 +0000 (UTC) From: "Marcus Eriksson (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11660) Dubious call to remove in CompactionManager.java MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257924#comment-15257924 ] Marcus Eriksson commented on CASSANDRA-11660: --------------------------------------------- Did you see the exception or did you find it by code inspection? We should probably remove that entire block of code, iirc it was a workaround before we had proper life cycle handling of sstables > Dubious call to remove in CompactionManager.java > ------------------------------------------------ > > Key: CASSANDRA-11660 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11660 > Project: Cassandra > Issue Type: Bug > Components: Compaction > Reporter: Max Schaefer > > I'm surprised by [this|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L1382] call to {{Iterator.remove()}} in {{org.apache.cassandra.db.compaction.antiCompactGroup}}: the iterator in question seems to come from [org.apache.cassandra.db.lifecycle.LifecycleTransaction.originals()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LifecycleTransaction.java#L419], which returns an unmodifiable set, so I would expect this call to always fail with an {{UnsupportedOperationException}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)