Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5075419B85 for ; Thu, 21 Apr 2016 15:07:27 +0000 (UTC) Received: (qmail 84327 invoked by uid 500); 21 Apr 2016 15:07:26 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 84232 invoked by uid 500); 21 Apr 2016 15:07:25 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 84047 invoked by uid 99); 21 Apr 2016 15:07:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 15:07:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8C6F02C1F60 for ; Thu, 21 Apr 2016 15:07:25 +0000 (UTC) Date: Thu, 21 Apr 2016 15:07:25 +0000 (UTC) From: "Marcus Eriksson (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CASSANDRA-11625) CFS.CANONICAL_SSTABLES adds compacting sstables without checking if they are still live MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Marcus Eriksson created CASSANDRA-11625: ------------------------------------------- Summary: CFS.CANONICAL_SSTABLES adds compacting sstables without checking if they are still live Key: CASSANDRA-11625 URL: https://issues.apache.org/jira/browse/CASSANDRA-11625 Project: Cassandra Issue Type: Bug Reporter: Marcus Eriksson Fix For: 2.1.x, 2.2.x In 2.1 and 2.2 we blindly add all compacting sstables to the ColumnFamilyStore.CANONICAL_SSTABLES This could cause issues as we unmark compacting after removing sstables from the tracker and compaction strategies. For example, when creating scanners for validation with LCS we might get overlap within a level as both the old sstables and the new ones could be in CANONICAL_SSTABLES What we need to do is to get the *version* of the sstable from the compacting set as it holds the original sstable without moved starts etc (that is what we do in 3.0+) -- This message was sent by Atlassian JIRA (v6.3.4#6332)