Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4CC1C19B97 for ; Wed, 20 Apr 2016 14:18:26 +0000 (UTC) Received: (qmail 251 invoked by uid 500); 20 Apr 2016 14:18:26 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 215 invoked by uid 500); 20 Apr 2016 14:18:25 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 99949 invoked by uid 99); 20 Apr 2016 14:18:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Apr 2016 14:18:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7B5012C1F60 for ; Wed, 20 Apr 2016 14:18:25 +0000 (UTC) Date: Wed, 20 Apr 2016 14:18:25 +0000 (UTC) From: "Sylvain Lebresne (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11617) The presence of custom index expressions doesn't set the indexing flag in StatementRestrictions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15249971#comment-15249971 ] Sylvain Lebresne commented on CASSANDRA-11617: ---------------------------------------------- bq. just that we need to do it with consideration, rather than as an accidental side-effect of some other change Of course. But I guess my point is, hasn't it always be the case in 3.x that custom indexes uses {{SinglePartitionReadCommand}}? Because if that's the case, you could argue that changing it could surprise some users and so I question the idea of switch to partition range query now (in 3.0.6/3.6) if we're going to change it back soon enough. Basically I'm suggesting to keep it just for custom index (since again, the change to the 2ndary index API are big enough in 3.x that I'm kind of more interested in keeping consistency in 3.x than trying to get back to pre-3.x behavior), maybe using this ticket to fix the few custom index specific things that are missing (the ones mentioned by [~adelapena]). We can then totally left switching the internal indexes to another ticket, which I definitively agree we'll have to test carefully. > The presence of custom index expressions doesn't set the indexing flag in StatementRestrictions > ----------------------------------------------------------------------------------------------- > > Key: CASSANDRA-11617 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11617 > Project: Cassandra > Issue Type: Bug > Components: CQL > Reporter: Sam Tunnicliffe > Assignee: Sam Tunnicliffe > Fix For: 3.0.x, 3.x > > > This can lead to queries with index expressions being executed as single partition rather than partition range reads, which should always be the case for index queries, even when the partition key is restricted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)