Return-Path: 
 <commits-return-166482-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-commits-archive@www.apache.org
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D749A19ACC
	for <apmail-cassandra-commits-archive@www.apache.org>;
 Wed, 13 Apr 2016 22:43:25 +0000 (UTC)
Received: (qmail 19182 invoked by uid 500); 13 Apr 2016 22:43:25 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 19148 invoked by uid 500); 13 Apr 2016 22:43:25 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 19136 invoked by uid 99); 13 Apr 2016 22:43:25 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 22:43:25 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 6C6672C1F4E
	for <commits@cassandra.apache.org>; Wed, 13 Apr 2016 22:43:25 +0000 (UTC)
Date: Wed, 13 Apr 2016 22:43:25 +0000 (UTC)
From: "Dikang Gu (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12958645.1460587203000.224508.1460587405440@Atlassian.JIRA>
In-Reply-To: <JIRA.12958645.1460587203000@Atlassian.JIRA>
References: <JIRA.12958645.1460587203000@Atlassian.JIRA>
 <JIRA.12958645.1460587203112@arcas>
Subject: [jira] [Updated] (CASSANDRA-11571) Optimize the overlapping lookup,
 by calculating all the bounds in advance.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CASSANDRA-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dikang Gu updated CASSANDRA-11571:
----------------------------------
    Fix Version/s: 3.x

> Optimize the overlapping lookup, by calculating all the bounds in advance.
> --------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11571
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11571
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Compaction
>            Reporter: Dikang Gu
>            Assignee: Dikang Gu
>             Fix For: 3.x
>
>
> When L0 sstable backs up (because of repair or other reasons), I find that a lot of CPU is using to construct the Bounds.
> {code}
> "CompactionExecutor:223" #1557 daemon prio=1 os_prio=4 tid=0x00007f88f401d800 nid=0x2303ab runnable [0x00007f824d735000]
>    java.lang.Thread.State: RUNNABLE
>         at org.apache.cassandra.dht.AbstractBounds.strictlyWrapsAround(AbstractBounds.java:86)
>         at org.apache.cassandra.dht.Bounds.<init>(Bounds.java:44)
>         at org.apache.cassandra.db.compaction.LeveledManifest.overlapping(LeveledManifest.java:533)
>         at org.apache.cassandra.db.compaction.LeveledManifest.overlapping(LeveledManifest.java:520)
>         at org.apache.cassandra.db.compaction.LeveledManifest.getCandidatesFor(LeveledManifest.java:595)
>         at org.apache.cassandra.db.compaction.LeveledManifest.getCompactionCandidates(LeveledManifest.java:349)
>         - locked <0x00007f8e11e67900> (a org.apache.cassandra.db.compaction.LeveledManifest)
>         at org.apache.cassandra.db.compaction.LeveledCompactionStrategy.getNextBackgroundTask(LeveledCompactionStrategy.java:97)
>         - locked <0x00007f8e11b1d780> (a org.apache.cassandra.db.compaction.LeveledCompactionStrategy)
>         at org.apache.cassandra.db.compaction.WrappingCompactionStrategy.getNextBackgroundTask(WrappingCompactionStrategy.java:78)
>         - locked <0x00007f8e110931a0> (a org.apache.cassandra.db.compaction.WrappingCompactionStrategy)
>         at org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionCandidate.run(CompactionManager.java:250)
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at java.lang.Thread.run(Thread.java:745)
> {code}
> From the code, we may construct the bounds multiply times, my patch optimizes it by calculating it in advance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)