Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Mon, 4 Apr 2016 08:12:25 +0000 (UTC)
From: "Robert Stupp (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12954640.1459346885000.123933.1459757545454@Atlassian.JIRA>
In-Reply-To: <JIRA.12954640.1459346885000@Atlassian.JIRA>
References: <JIRA.12954640.1459346885000@Atlassian.JIRA>
 <JIRA.12954640.1459346885686@arcas>
Subject: [jira] [Commented] (CASSANDRA-11462) IncomingStreamingConnection
 version check message wrong
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223806#comment-15223806 ] 

Robert Stupp commented on CASSANDRA-11462:
------------------------------------------

[~RyanMagnusson] lgtm

[~slebresne] any objections to commit this to 2.1? Should help to identify streaming issues in the C* log.

> IncomingStreamingConnection version check message wrong
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11462
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11462
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Priority: Trivial
>
> If compares against {{StreamMessage.CURRENT_VERSION}} but prints {{MessagingService.current_version}}. The error message is confusing tho.
> {code}
>             if (version != StreamMessage.CURRENT_VERSION)
>                 throw new IOException(String.format("Received stream using protocol version %d (my version %d). Terminating connection", version, MessagingService.current_version));
> {code}
> EDIT: That message is only printed at debug log level


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)