Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EED8319AF6 for ; Fri, 15 Apr 2016 13:38:25 +0000 (UTC) Received: (qmail 9732 invoked by uid 500); 15 Apr 2016 13:38:25 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 9704 invoked by uid 500); 15 Apr 2016 13:38:25 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 9679 invoked by uid 99); 15 Apr 2016 13:38:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 13:38:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8013F2C14F7 for ; Fri, 15 Apr 2016 13:38:25 +0000 (UTC) Date: Fri, 15 Apr 2016 13:38:25 +0000 (UTC) From: "T Jake Luciani (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-11422) Eliminate temporary object[] allocations in ColumnDefinition::hashCode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] T Jake Luciani updated CASSANDRA-11422: --------------------------------------- Resolution: Fixed Status: Resolved (was: Patch Available) Resolved in CASSANDRA-11428 > Eliminate temporary object[] allocations in ColumnDefinition::hashCode > ---------------------------------------------------------------------- > > Key: CASSANDRA-11422 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11422 > Project: Cassandra > Issue Type: Sub-task > Components: Core > Reporter: Nitsan Wakart > Assignee: Nitsan Wakart > > ColumnDefinition::hashCode currently calls Objects.hashCode(Object...) > This triggers the allocation of a short lived Object[] which is not eliminated by EscapeAnalysis. I have implemented a fix by inlining the hashcode logic and also added a caching hashcode field. This improved performance on the read workload. > Fix is available here: > https://github.com/nitsanw/cassandra/tree/objects-hashcode-fix -- This message was sent by Atlassian JIRA (v6.3.4#6332)