Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 388A219221 for ; Mon, 25 Apr 2016 21:34:18 +0000 (UTC) Received: (qmail 57975 invoked by uid 500); 25 Apr 2016 21:34:13 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 57939 invoked by uid 500); 25 Apr 2016 21:34:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 57912 invoked by uid 99); 25 Apr 2016 21:34:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 21:34:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CB44B2C1F5C for ; Mon, 25 Apr 2016 21:34:12 +0000 (UTC) Date: Mon, 25 Apr 2016 21:34:12 +0000 (UTC) From: "Joel Knighton (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-11402) Alignment wrong in tpstats output for PerDiskMemtableFlushWriter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257093#comment-15257093 ] Joel Knighton commented on CASSANDRA-11402: ------------------------------------------- That looks like the right approach - as I mentioned in the comment above, it would be great if we also fixed the output in org.apache.cassandra.utils.StatusLogger. That said, since he is Assignee, let me check with [~RyanMagnusson] - do you have a problem with [~nkelkar] taking over this ticket or would you prefer to revise your patch based on my comment above? > Alignment wrong in tpstats output for PerDiskMemtableFlushWriter > ---------------------------------------------------------------- > > Key: CASSANDRA-11402 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11402 > Project: Cassandra > Issue Type: Bug > Reporter: Joel Knighton > Assignee: Ryan Magnusson > Priority: Trivial > Labels: lhf > Fix For: 3.x > > Attachments: 11402-3_5_patch1.patch, 11402-trunk.txt > > > With the accompanying designation of which memtableflushwriter it is, this threadpool name is too long for the hardcoded padding in tpstats output. > We should dynamically calculate padding so that we don't need to check this every time we add a threadpool. -- This message was sent by Atlassian JIRA (v6.3.4#6332)