cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11660) Dubious call to remove in CompactionManager.java
Date Tue, 26 Apr 2016 11:46:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257936#comment-15257936
] 

Marcus Eriksson commented on CASSANDRA-11660:
---------------------------------------------

Nice catch!

This should never happen since we now (2.2+) manage references to sstables in a better way,
so all sstables should exist when we get there. 

I've submitted a [branch|https://github.com/krummas/cassandra/commits/marcuse/11660] for testing:
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-11660-testall/
http://cassci.datastax.com/view/Dev/view/krummas/job/krummas-marcuse-11660-dtest/



> Dubious call to remove in CompactionManager.java
> ------------------------------------------------
>
>                 Key: CASSANDRA-11660
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11660
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Max Schaefer
>            Priority: Minor
>
> I'm surprised by [this|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/compaction/CompactionManager.java#L1382]
call to {{Iterator.remove()}} in {{org.apache.cassandra.db.compaction.antiCompactGroup}}:
the iterator in question seems to come from [org.apache.cassandra.db.lifecycle.LifecycleTransaction.originals()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/db/lifecycle/LifecycleTransaction.java#L419],
which returns an unmodifiable set, so I would expect this call to always fail with an {{UnsupportedOperationException}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message