cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11579) remove DatabaseDescriptor dependency from SequentialWriter
Date Fri, 15 Apr 2016 07:48:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242597#comment-15242597
] 

Robert Stupp commented on CASSANDRA-11579:
------------------------------------------

The rest was easier than I expected. Some more comments:
* {{CompressedSequentialWriter}} declares {{private final Optional<File> digestFile;}}.
Can you make this a simple {{File digestFile;}}?
* Removal of {{SequentialWriter.descriptor}} and these {{setDescriptor(descriptor).doSomething()}}
is nice!
* Do you think it makes sense to keep the {{SequentialWriterOption}} in {{SequentialWriter}}
instead of the fields {{trickleFsync}}, {{trickleFsyncByteInterval}} and {{finishOnClose}}?
* Regarding your comment for {{trickleFsync}} in the description, I don't see the actual change.
Can you give me a heads-up?



> remove DatabaseDescriptor dependency from SequentialWriter
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-11579
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11579
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>
> {{SequentialWriter}} and its subclass is widely used in Cassandra, mainly from SSTable.
Removing dependency to {{DatabaseDescriptor}} improve reusability of this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message