cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11579) remove DatabaseDescriptor dependency from SequentialWriter
Date Fri, 15 Apr 2016 07:07:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15242558#comment-15242558
] 

Robert Stupp commented on CASSANDRA-11579:
------------------------------------------

Didn't review everything yet (looks good from a brief look), but some comments so far:
* Can you rename {{org.apache.cassandra.io.util.SequentialWriterOption#configure}} to {{newBuilder}}
and {{org.apache.cassandra.io.util.SequentialWriterOption.Configurator#finish}} to {{build}}
and {{org.apache.cassandra.io.util.SequentialWriterOption.Configurator}} to {{Builder}}?
* The testall run shows some error - I don't think these are related to your patch, but can
you recheck?
* Introduce a constant in {{ChecksummedSequentialWriter}} for {{SequentialWriterOption.configure().bufferSize(8
* 1024).finish()}}
* Introduce a constant in {{OnDiskIndexBuilder}} for {{SequentialWriterOption.configure().bufferSize(BLOCK_SIZE).finish()}}


> remove DatabaseDescriptor dependency from SequentialWriter
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-11579
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11579
>             Project: Cassandra
>          Issue Type: Sub-task
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>
> {{SequentialWriter}} and its subclass is widely used in Cassandra, mainly from SSTable.
Removing dependency to {{DatabaseDescriptor}} improve reusability of this class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message