cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuki Morishita (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11479) BatchlogManager unit tests failing on truncate race condition
Date Fri, 22 Apr 2016 02:33:12 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15253216#comment-15253216
] 

Yuki Morishita commented on CASSANDRA-11479:
--------------------------------------------

||branch||testall||dtest||
|[11479-2.2|https://github.com/yukim/cassandra/tree/11479-2.2]|[testall|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11479-2.2-testall/lastCompletedBuild/testReport/]|[dtest|http://cassci.datastax.com/view/Dev/view/yukim/job/yukim-11479-2.2-dtest/lastCompletedBuild/testReport/]|

I created patch for 2.2 to see if this works.
Basically added one more condition to {{isCompacting}} to check if table is in {{compactingCF}}.
Table is added to {{compactingCF}} in {{submitBackground}} and removed at the end of {{BackgroundCompactionCandidate#run}}.

> BatchlogManager unit tests failing on truncate race condition
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-11479
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11479
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Joel Knighton
>            Assignee: Yuki Morishita
>             Fix For: 2.2.x, 3.0.x, 3.x
>
>         Attachments: TEST-org.apache.cassandra.batchlog.BatchlogManagerTest.log
>
>
> Example on CI [here|http://cassci.datastax.com/job/trunk_testall/818/testReport/junit/org.apache.cassandra.batchlog/BatchlogManagerTest/testLegacyReplay_compression/].
This seems to have only started happening relatively recently (within the last month or two).
> As far as I can tell, this is only showing up on BatchlogManagerTests purely because
it is an aggressive user of truncate. The assertion is hit in the setUp method, so it can
happen before any of the test methods. The assertion occurs because a compaction is happening
when truncate wants to discard SSTables; trace level logs suggest that this compaction is
submitted after the pause on the CompactionStrategyManager.
> This should be reproducible by running BatchlogManagerTest in a loop - it takes up to
half an hour in my experience. A trace-level log from such a run is attached - grep for my
added log message "SSTABLES COMPACTING WHEN DISCARDING" to find when the assert is hit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message