cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11474) cqlsh: COPY FROM should use regular inserts for single statement batches
Date Thu, 14 Apr 2016 13:13:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241121#comment-15241121
] 

Paulo Motta commented on CASSANDRA-11474:
-----------------------------------------

LGTM, but given that CASSANDRA-10876 removed this limitation for single partition batches
on trunk, special casing single mutation batches on COPY FROM doesn't bring us much additional
benefits, so I think we should include this only on 2.2 and 3.0 for code simplicity.

Could you provide a trunk patch without the single insert optimization, but only with the
error report and empty chunk fixes?

> cqlsh: COPY FROM should use regular inserts for single statement batches
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11474
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11474
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tools
>            Reporter: Stefania
>            Assignee: Stefania
>            Priority: Minor
>              Labels: lhf
>             Fix For: 2.2.x, 3.0.x, 3.x
>
>
> I haven't reproduced it with a test yet but, from code inspection, if CQL rows are larger
than {{batch_size_fail_threshold_in_kb}} and this parameter cannot be changed, then data import
will fail.
> Users can control the batch size by setting MAXBATCHSIZE.
> If a batch contains a single statement, there is no need to use a batch and we should
use normal inserts instead or, alternatively, we should skip the batch size check for unlogged
batches with only one statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message