cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11462) IncomingStreamingConnection version check message wrong
Date Sun, 03 Apr 2016 07:02:29 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223143#comment-15223143
] 

Robert Stupp commented on CASSANDRA-11462:
------------------------------------------

Correction of the message is correct. Can you add two things?
* a {{logger.error}} in the catch block that prints the error without the stack trace (but
leave the stack trace with trace level)
* add the remote IP to the messages in the catch block


> IncomingStreamingConnection version check message wrong
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11462
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11462
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Priority: Trivial
>
> If compares against {{StreamMessage.CURRENT_VERSION}} but prints {{MessagingService.current_version}}.
The error message is confusing tho.
> {code}
>             if (version != StreamMessage.CURRENT_VERSION)
>                 throw new IOException(String.format("Received stream using protocol version
%d (my version %d). Terminating connection", version, MessagingService.current_version));
> {code}
> EDIT: That message is only printed at debug log level



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message