cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "DOAN DuyHai (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-11183) Enable SASI index for static columns
Date Sun, 03 Apr 2016 15:34:25 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-11183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

DOAN DuyHai updated CASSANDRA-11183:
------------------------------------
    Attachment: patch_SASI_for_Static_AFTER_Review.txt

Ok, after [~xedin] remarks, I have updated the patch.

Now *normal* and *static* rows are passed together to {{operation.satisfiedBy(Unfiltered,
Row, allowMissings)}} and {{operation.localSatisfiedBy(Unfiltered, Row, allowMissings)}}

However, I did not modify the method {{ColumnIndex.getValueOf(column, row, nowInSecs)}} because
it is used at many places where we may not have access to static row.

Instead I added a new method  {{ColumnIndex.getValueOfStatic(column, staticRow, nowInSecs)}}


This method will be called by

* {{ColumnIndex.index(DecoratedKey, Row)}}
* {{operation.localSatisfiedBy(Unfiltered, Row, allowMissings)}}

For test coverage, in addition of existing {{SASIIndexTest.testStaticIndex}}, I also added
{{OperationTest.testSatisfiedByWithStatic}} which combines

# static AND non static conditions
# static OR non static conditions
# (static OR static conditions) AND  static conditions

All tests are green

> Enable SASI index for static columns
> ------------------------------------
>
>                 Key: CASSANDRA-11183
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11183
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: DOAN DuyHai
>            Assignee: DOAN DuyHai
>            Priority: Minor
>             Fix For: 3.6
>
>         Attachments: patch_SASI_for_Static_AFTER_Review.txt
>
>
> This is a follow up ticket for post Cassandra 3.4 SASI integration.
> Since [CASSANDRA-8103] it is possible to index static columns, which is *extremely useful*
for some scenarios (find all sensors whose characteristics are saved in static columns)
> /cc [~xedin] [~rustyrazorblade] [~jkrupan]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message