cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-10624) Support UDT in CQLSSTableWriter
Date Wed, 13 Apr 2016 06:23:25 GMT


Alex Petrov commented on CASSANDRA-10624:

Thank you for the review! 
I've addressed all the comments:

  * I think I've got this {{static}} habit from Clojure :/ static methods for utility class.
Also, it's easy to check / make sure you didn't miss any dep on the surrounding class. I should've
removed it before commit.
  * added IDE rule to do it as you say (group imports with {{*}}). I think the order was alphabetical
({{c.d.driver.*}} vs {{c.a.cassandra.*}})
  * and removed blank lines (missed those somehow)


(it should not influence anything as it's mostly minor changes, although rerunning utests
just in case)

> Support UDT in CQLSSTableWriter
> -------------------------------
>                 Key: CASSANDRA-10624
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Sylvain Lebresne
>            Assignee: Alex Petrov
>             Fix For: 3.x
>         Attachments: 0001-Add-support-for-UDTs-to-CQLSStableWriter.patch, 0001-Support-UDTs-in-CQLSStableWriterV2.patch
> As far as I can tell, there is not way to use a UDT with {{CQLSSTableWriter}} since there
is no way to declare it and thus {{CQLSSTableWriter.Builder}} knows of no UDT when parsing
the {{CREATE TABLE}} statement passed.
> In terms of API, I think the simplest would be to allow to pass types to the builder
in the same way we pass the table definition. So something like:
> {noformat}
> String type = "CREATE TYPE myKs.vertex (x int, y int, z int)";
> String schema = "CREATE TABLE myKs.myTable ("
>               + "  k int PRIMARY KEY,"
>               + "  s set<vertex>"
>               + ")";
> String insert = ...;
> CQLSSTableWriter writer = CQLSSTableWriter.builder()
>                                           .inDirectory("path/to/directory")
>                                           .withType(type)
>                                           .forTable(schema)
>                                           .using(insert).build();
> {noformat}
> I'll note that implementation wise, this might be a bit simpler after the changes of
CASSANDRA-10365 (as it makes it easy to passe specific types during the preparation of the
create statement).

This message was sent by Atlassian JIRA

View raw message