Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C310318C19 for ; Thu, 10 Mar 2016 19:56:41 +0000 (UTC) Received: (qmail 87046 invoked by uid 500); 10 Mar 2016 19:56:41 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 86941 invoked by uid 500); 10 Mar 2016 19:56:41 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 86894 invoked by uid 99); 10 Mar 2016 19:56:41 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Mar 2016 19:56:41 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DE0A52C1F54 for ; Thu, 10 Mar 2016 19:56:40 +0000 (UTC) Date: Thu, 10 Mar 2016 19:56:40 +0000 (UTC) From: "Anubhav Kale (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-11168) Hint Metrics are updated even if hinted_hand-offs=false MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anubhav Kale updated CASSANDRA-11168: ------------------------------------- Attachment: 0001-Hinted-handoffs-fix.patch > Hint Metrics are updated even if hinted_hand-offs=false > ------------------------------------------------------- > > Key: CASSANDRA-11168 > URL: https://issues.apache.org/jira/browse/CASSANDRA-11168 > Project: Cassandra > Issue Type: Bug > Reporter: Anubhav Kale > Assignee: Anubhav Kale > Priority: Minor > Attachments: 0001-Hinted-Handoff-Fix.patch, 0001-Hinted-Handoff-fix-2_2.patch, 0001-Hinted-handoff-metrics.patch, 0001-Hinted-handoffs-fix.patch > > > In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted handoffs. > The reason is StorageProxy.ShouldHint has an inverted if condition. > We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()). > The fix is easy, and I can provide a patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)