Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D4C70182C6 for ; Tue, 15 Mar 2016 19:28:38 +0000 (UTC) Received: (qmail 32530 invoked by uid 500); 15 Mar 2016 19:28:33 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 32500 invoked by uid 500); 15 Mar 2016 19:28:33 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 32479 invoked by uid 99); 15 Mar 2016 19:28:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Mar 2016 19:28:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6ACAD2C14FB for ; Tue, 15 Mar 2016 19:28:33 +0000 (UTC) Date: Tue, 15 Mar 2016 19:28:33 +0000 (UTC) From: "Ariel Weisberg (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CASSANDRA-10971) Compressed commit log has no backpressure and can OOM MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ariel Weisberg updated CASSANDRA-10971: --------------------------------------- Status: Open (was: Patch Available) Have the tests running again. I think it's a test specific issue where the commit log isn't shut down correctly in the tests. Will go patch available if that fixes the issue. > Compressed commit log has no backpressure and can OOM > ----------------------------------------------------- > > Key: CASSANDRA-10971 > URL: https://issues.apache.org/jira/browse/CASSANDRA-10971 > Project: Cassandra > Issue Type: Bug > Components: Local Write-Read Paths > Reporter: Ariel Weisberg > Assignee: Ariel Weisberg > Fix For: 3.0.x, 3.x > > > I validated this via a unit test that slowed the ability of the log to drain to the filesystem. The compressed commit log will keep allocating buffers pending compression until it OOMs. > I have a fix that am not very happy with because the whole signal a thread to allocate a segment that depends on a resource that may not be available results in some obtuse usage of {{CompleatableFuture}} to rendezvous available buffers with {{CommitLogSegmentManager}} thread waiting to finish constructing a new segment. The {{CLSM}} thread is in turn signaled by the thread(s) that actually wants to write to the next segment, but aren't able to do it themselves. -- This message was sent by Atlassian JIRA (v6.3.4#6332)