Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 30 Mar 2016 03:54:25 +0000 (UTC)
From: "Joel Knighton (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12841940.1435742744000.84099.1459310065587@Atlassian.JIRA>
In-Reply-To: <JIRA.12841940.1435742744000@Atlassian.JIRA>
References: <JIRA.12841940.1435742744000@Atlassian.JIRA>
 <JIRA.12841940.1435742744435@arcas>
Subject: [jira] [Commented] (CASSANDRA-9692) Print sensible units for all
 log messages
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217339#comment-15217339 ] 

Joel Knighton commented on CASSANDRA-9692:
------------------------------------------

Great work on this - it's hard enough to contribute to one OSS project, let alone coordinate a change across three spanning two programming languages and two processes to contribute.

The CCM changes were merged in [PR #485|https://github.com/pcmanus/ccm/pull/485] to the pcmanus/ccm repo. The dtest changes have been PRed in [PR #899|https://github.com/riptano/cassandra-dtest/pull/899] to the riptano/cassandra-dtest repo and will be merged after this ticket is committed to C*.

Latest CI runs with the changes made to CCM and dtest look clean relative to upstream.

Final branch here:
||branch||testall||dtest||
|[9692-trunk|https://github.com/jkni/cassandra/tree/9692-trunk]|[testall|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9692-trunk-testall]|[dtest|http://cassci.datastax.com/view/Dev/view/jkni/job/jkni-9692-trunk-dtest]|

Note to committer: this should only go to trunk. It is rebased on latest trunk so should merge fine.

> Print sensible units for all log messages
> -----------------------------------------
>
>                 Key: CASSANDRA-9692
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9692
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benedict
>            Assignee: Giampaolo
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.x
>
>         Attachments: Cassandra9692-Rev1-trunk-giampaolo-trapasso-at-radicalbit-io.diff, Cassandra9692-Rev2-trunk-giampaolo.trapasso-at-radicalbit-io.diff, Cassandra9692-trunk-giampaolo-trapasso-at-radicalbit-io.diff, ccm-bb08b6798f3fda39217f2daf710116a84a3ede84.patch, dtests-8a1017398ab55a4648fcc307a9be0644c02602dd.patch
>
>
> Like CASSANDRA-9691, this has bugged me too long. it also adversely impacts log analysis. I've introduced some improvements to the bits I touched for CASSANDRA-9681, but we should do this across the codebase. It's a small investment for a lot of long term clarity in the logs.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)