Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 16 Mar 2016 15:39:33 +0000 (UTC)
From: "Yuki Morishita (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12610357.1349368793000.36680.1458142773618@Atlassian.JIRA>
In-Reply-To: <JIRA.12610357.1349368793000@Atlassian.JIRA>
References: <JIRA.12610357.1349368793000@Atlassian.JIRA>
 <JIRA.12610357.1349368793428@arcas>
Subject: [jira] [Commented] (CASSANDRA-4763) SSTableLoader shouldn't get
 keyspace from path
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15197521#comment-15197521 ] 

Yuki Morishita commented on CASSANDRA-4763:
-------------------------------------------

After CASSANDRA-6962, SSTable file does not have keyspace and table name anymore.
So inferring keyspace and table name from file name is not possible.

But there maybe a use case that users want to load SSTables to different keyspace and table(of course, this may fail because of incompatibility).
Then, specifying keyspace and table name through command line option maybe useful.

> SSTableLoader shouldn't get keyspace from path
> ----------------------------------------------
>
>                 Key: CASSANDRA-4763
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4763
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Nick Bailey
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 2.1.x
>
>
> SSTableLoader currently gets the keyspace it is going to load to from the path of the directoy of sstables it is loading. This isn't really documented (or I didn't see it), but also isn't really a good way of doing it in general.
> {noformat}
> this.keyspace = directory.getParentFile().getName();
> {noformat}
> We should probably just let users pass the name in. If you are loading a snapshot the file names will have the keyspace which is slightly better but people manually creating their own sstables might not format them the same.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)