cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dikang Gu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-11450) Should not search for the index of a column if the table is not using secondaryIndex.
Date Mon, 28 Mar 2016 23:48:25 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-11450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dikang Gu updated CASSANDRA-11450:
----------------------------------
    Attachment: 0001-return-nullupdater-for-table-do-not-have-indexes.patch

> Should not search for the index of a column if the table is not using secondaryIndex.
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11450
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11450
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Compaction
>            Reporter: Dikang Gu
>            Assignee: Dikang Gu
>             Fix For: 2.2.x
>
>         Attachments: 0001-return-nullupdater-for-table-do-not-have-indexes.patch
>
>
> We are not using secondary index in our cluster, but when I profile the compaction, I
find that ~5.5% of the compaction time is spent on this line of the code function LazilyCompactedRow.Reducer.reduce():
>   if (cell.isLive() && !container.getColumn(cell.name()).equals(cell))
> before this line there is check to skip the look up, which seems to be not working:
>   // skip the index-update checks if there is no indexing needed since they are a bit
expensive
>   if (indexer == SecondaryIndexManager.nullUpdater)
>       return;
> My patch is to set the indexer to be nullUpdater if the table has no associated index.
> Let me know if it's the right fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message