cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Branimir Lambov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-11448) Running OOS should trigger the disk failure policy
Date Thu, 31 Mar 2016 07:41:25 GMT


Branimir Lambov commented on CASSANDRA-11448:

Patch here:
2.1 patch applies cleanly up to 3.0 (disregarding {{CHANGES.txt}} conflicts), trunk is different.

Changes the error thrown to {{FSWriteError}}, applies {{JVMStabilityInspector}}, passes it
on to the post-flush instead of failing to trigger it, and makes sure commit log is not discarded
for failed flushes. Trunk version also removes unused {{DiskAwareRunnable}} and fixes {{null}}
return from {{getWriteableLocation}} not being treated properly.

> Running OOS should trigger the disk failure policy
> --------------------------------------------------
>                 Key: CASSANDRA-11448
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Brandon Williams
>            Assignee: Branimir Lambov
>             Fix For: 2.1.x, 2.2.x, 3.0.x, 3.x
> Currently when you run OOS, this happens:
> {noformat}
> ERROR [MemtableFlushWriter:8561] 2016-03-28 01:17:37,047 -
Exception in thread Thread[MemtableFlushWriter:8561,5,main]   java.lang.RuntimeException:
Insufficient disk space to write 48 bytes 
>     at
>     at org.apache.cassandra.db.Memtable$FlushRunnable.runMayThrow(
>     at ~[cassandra-all-]
>     at$SameThreadExecutorService.execute(
>     at org.apache.cassandra.db.ColumnFamilyStore$
>     at java.util.concurrent.ThreadPoolExecutor.runWorker(
>     at java.util.concurrent.ThreadPoolExecutor$
>     at ~[na:1.8.0_66]
> {noformat}
> Now your flush writer is dead and postflush tasks build up forever.  Instead we should
throw FSWE and trigger the failure policy.

This message was sent by Atlassian JIRA

View raw message