cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11370) Display sstable count per level according to repair status on nodetool tablestats
Date Thu, 17 Mar 2016 16:26:33 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15199835#comment-15199835
] 

Paulo Motta commented on CASSANDRA-11370:
-----------------------------------------

Attaching patch. Below is manual test output with {{ccm}}:
{noformat}
ccm create test -n 2
ccm start
ccm node1 stress "write n=100K cl=QUORUM -rate threads=300 -schema replication(factor=2) compaction(strategy=org.apache.cassandra.db.compaction.LeveledCompactionStrategy,sstable_size_in_mb=1)"
ccm flush
ccm node1 nodetool tablestats keyspace1.standard1

SSTable count: 22
SSTables in each level (repaired): [0, 0, 0, 0, 0, 0, 0, 0, 0]
SSTables in each level (unrepaired): [0, 10, 12, 0, 0, 0, 0, 0, 0]
Space used (live): 25017410
Space used (total): 25017410

ccm node1 nodetool repair keyspace1 standard1

SSTable count: 22
SSTables in each level (repaired): [0, 10, 12, 0, 0, 0, 0, 0, 0]
SSTables in each level (unrepaired): [0, 0, 0, 0, 0, 0, 0, 0, 0]
Space used (live): 25017410
Space used (total): 25017410

ccm node1 stress "write n=150K cl=QUORUM -rate threads=300 -schema replication(factor=2) compaction(strategy=org.apache.cassandra.db.compaction.LeveledCompactionStrategy,sstable_size_in_mb=1)"
ccm flush
ccm node1 nodetool tablestats keyspace1.standard1

Table: standard1
SSTable count: 56
SSTables in each level (repaired): [0, 10, 12, 0, 0, 0, 0, 0, 0]
SSTables in each level (unrepaired): [0, 10, 24, 0, 0, 0, 0, 0, 0]
Space used (live): 62554649
Space used (total): 62554649

ccm node1 nodetool repair keyspace1 standard1

SSTable count: 50
SSTables in each level (repaired): [0, 10, 40, 0, 0, 0, 0, 0, 0]
SSTables in each level (unrepaired): [0, 0, 0, 0, 0, 0, 0, 0, 0]
Space used (live): 46033951
Space used (total): 46033951
{noformat}

Patch and tests below:
||trunk||
|[branch|https://github.com/apache/cassandra/compare/trunk...pauloricardomg:trunk-11370]|
|[testall|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-11370-testall/lastCompletedBuild/testReport/]|
|[dtest|http://cassci.datastax.com/view/Dev/view/paulomotta/job/pauloricardomg-trunk-11370-dtest/lastCompletedBuild/testReport/]|

Would you mind reviewing [~krummas]? Thanks!

> Display sstable count per level according to repair status on nodetool tablestats 
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11370
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11370
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Paulo Motta
>            Priority: Minor
>              Labels: lhf
>
> After CASSANDRA-8004 we still display sstables in each level on nodetool tablestats as
if we had a single compaction strategy, while we have one strategy for repaired and another
for unrepaired data. 
> We should split display into repaired and unrepaired set, so this:
> SSTables in each level: [2, 20/10, 15, 0, 0, 0, 0, 0, 0]
> Would become:
> SSTables in each level (repaired): [1, 10, 0, 0, 0, 0, 0, 0, 0]
> SSTables in each level (unrepaired): [1, 10, 15, 0, 0, 0, 0, 0, 0]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message