cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-11354) PrimaryKeyRestrictionSet should be refactored
Date Wed, 16 Mar 2016 16:04:33 GMT


Alex Petrov commented on CASSANDRA-11354:

Is {{AbstractSingleRestriction}} still required as an abstract class? It's also possible to
implement the {{false}} returning methods on the interface directly. 

> PrimaryKeyRestrictionSet should be refactored
> ---------------------------------------------
>                 Key: CASSANDRA-11354
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Benjamin Lerer
>            Assignee: Benjamin Lerer
> While reviewing CASSANDRA-11310 I realized that the code of {{PrimaryKeyRestrictionSet}}
was really confusing.
> The main 2 issues are:
> * the fact that it is used for partition keys and clustering columns restrictions whereas
those types of column required different processing
> * the {{isEQ}}, {{isSlice}}, {{isIN}} and {{isContains}} methods should not be there
as the set of restrictions might not match any of those categories when secondary indexes
are used.

This message was sent by Atlassian JIRA

View raw message