cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Petrov (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-11310) Allow filtering on clustering columns for queries without secondary indexes
Date Wed, 16 Mar 2016 21:30:33 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195464#comment-15195464
] 

Alex Petrov edited comment on CASSANDRA-11310 at 3/16/16 9:30 PM:
------------------------------------------------------------------

That totally makes sense. I've added tests for the {{CONTAINS}} restrictions on the frozen
collections (list and map).

Also, have addressed your other comments
  * renamed {{useFiltering}} to {{allowFiltering}}. I've sticked to the previously existing
naming ({{useFiltering}} was already there, so I hesitated to change it at first)
  * renamed {{indexRestrictions}} to {{filteringRestrictions}} 
  * addressed {{StatementRestriction}} comments by checking whether we're doing filtering
and adding {{clusteringColumnsRestrictions}} to {{filteringRestrictions}}, removed changes
to {{getRowFilter}}

I have still pushed to the same branch: https://github.com/ifesdjeen/cassandra/compare/trunk...cassandra-11310


was (Author: ifesdjeen):
That totally makes sense. I've added tests for the {{CONTAINS}} restrictions on the frozen
collections (list and map).

Also, have addressed your other comments
  * renamed {{useFiltering}} to {{allowFiltering}}. I've sticked to the previously existing
naming ({{useFiltering}} was already there, so I hesitated to change it at first)
  * renamed {{indexRestrictions}} to {{filteringRestrictions}} 
  * addressed {{StatementRestriction}} comments by checking whether we're doing filtering
and adding {{clusteringColumnsRestrictions}} to {{filteringRestrictions}}, removed changes
to {{getRowFilter}}

I have still pushed to the same branch: https://github.com/ifesdjeen/cassandra/commit/991c28b7b7ad8debbccfa9faed1b012f2388c231

> Allow filtering on clustering columns for queries without secondary indexes
> ---------------------------------------------------------------------------
>
>                 Key: CASSANDRA-11310
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11310
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: CQL
>            Reporter: Benjamin Lerer
>            Assignee: Alex Petrov
>              Labels: doc-impacting
>             Fix For: 3.x
>
>
> Since CASSANDRA-6377 queries without index filtering non-primary key columns are fully
supported.
> It makes sense to also support filtering on clustering-columns.
> {code}
> CREATE TABLE emp_table2 (
> empID int,
> firstname text,
> lastname text,
> b_mon text,
> b_day text,
> b_yr text,
> PRIMARY KEY (empID, b_yr, b_mon, b_day));
> SELECT b_mon,b_day,b_yr,firstname,lastname FROM emp_table2
> WHERE b_mon='oct' ALLOW FILTERING;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message