cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulo Motta (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11217) Only log yaml config once, at startup
Date Wed, 02 Mar 2016 19:48:18 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176339#comment-15176339
] 

Paulo Motta commented on CASSANDRA-11217:
-----------------------------------------

LGTM, marking as ready to commit. Thanks!

> Only log yaml config once, at startup
> -------------------------------------
>
>                 Key: CASSANDRA-11217
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11217
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Configuration, Core
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>
> CASSANDRA-6456 introduced a feature where the yaml is dumped in the log. At startup this
is a nice feature, but I see that it’s actually triggered every time it handshakes with
a node and fails to connect and the node happens to be a seed ([see here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/net/OutboundTcpConnection.java#L435]).
Calling {{DD.getseeds()}} calls the {{SeedProvider}}, and if you happen to use {{SimpleSeedProvider}}
it will reload the yaml config, and once again dump it out to the log.
> It's debatable if {{DD.getseeds()}} should trigger a reload (which I added in CASSANDRA-5459)
or whether reloading the seeds should be a different method (it probably should), but we shouldn't
keep logging the yaml config on every connection failure to a seed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message