cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Brown (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-11217) Only log yaml config once, at startup
Date Wed, 02 Mar 2016 00:25:18 GMT


Jason Brown commented on CASSANDRA-11217:

bq. how about moving the actual logging to {{DatabaseDescriptor}} so we don't need to change
the {{ConfigurationLoader}}

Good call. I've moved the logging into {{Config#log}}, and is still invoked from DD the way
it was in the first patch.

bq. maybe decrease the log level to {{DEBUG}}


Tests running now.

|| 2.2 | 3.0 | trunk||

> Only log yaml config once, at startup
> -------------------------------------
>                 Key: CASSANDRA-11217
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Configuration, Core
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
> CASSANDRA-6456 introduced a feature where the yaml is dumped in the log. At startup this
is a nice feature, but I see that it’s actually triggered every time it handshakes with
a node and fails to connect and the node happens to be a seed ([see here|]).
Calling {{DD.getseeds()}} calls the {{SeedProvider}}, and if you happen to use {{SimpleSeedProvider}}
it will reload the yaml config, and once again dump it out to the log.
> It's debatable if {{DD.getseeds()}} should trigger a reload (which I added in CASSANDRA-5459)
or whether reloading the seeds should be a different method (it probably should), but we shouldn't
keep logging the yaml config on every connection failure to a seed.

This message was sent by Atlassian JIRA

View raw message