cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-11168) Hint Metrics are updated even if hinted_hand-offs=false
Date Mon, 14 Mar 2016 16:23:33 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Joel Knighton updated CASSANDRA-11168:
--------------------------------------
    Fix Version/s: 3.0.x
                   2.2.x
                   3.5
      Component/s: Observability
                   Coordination

> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11168
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11168
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Coordination, Observability
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>             Fix For: 3.5, 2.2.x, 3.0.x
>
>         Attachments: 0001-Hinted-Handoff-Fix.patch, 0001-Hinted-Handoff-fix-2_2.patch,
0001-Hinted-handoff-metrics.patch, 0001-Hinted-handoffs-fix.patch
>
>
> In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted
handoffs.
> The reason is StorageProxy.ShouldHint has an inverted if condition. 
> We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message