cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-11168) Hint Metrics are updated even if hinted_hand-offs=false
Date Mon, 14 Mar 2016 16:22:33 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-11168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193558#comment-15193558
] 

Joel Knighton commented on CASSANDRA-11168:
-------------------------------------------

+1. CI looks clean - I ran for 2.2, 3.0, 3.5, and trunk.

For committer: there are two patches to be applied. One for 2.2 and one for 3.0+. These are
the two most recent patches attached to the issue. The 2.2 patch is attached to the issue
as 0001-Hinted-Handoff-fix-2_2.patch. The 3.0+ patch is attached to the issue as 0001-Hinted-handoffs-fix.patch.
This patch should merge forward cleanly up to trunk.

> Hint Metrics are updated even if hinted_hand-offs=false
> -------------------------------------------------------
>
>                 Key: CASSANDRA-11168
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11168
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Anubhav Kale
>            Assignee: Anubhav Kale
>            Priority: Minor
>         Attachments: 0001-Hinted-Handoff-Fix.patch, 0001-Hinted-Handoff-fix-2_2.patch,
0001-Hinted-handoff-metrics.patch, 0001-Hinted-handoffs-fix.patch
>
>
> In our PROD logs, we noticed a lot of hint metrics even though we have disabled hinted
handoffs.
> The reason is StorageProxy.ShouldHint has an inverted if condition. 
> We should also wrap the if (hintWindowExpired) block in if (DatabaseDescriptor.hintedHandoffEnabled()).
> The fix is easy, and I can provide a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message