cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joel Knighton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-9692) Print sensible units for all log messages
Date Mon, 28 Mar 2016 19:33:25 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-9692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214736#comment-15214736
] 

Joel Knighton commented on CASSANDRA-9692:
------------------------------------------

Thanks - a few small things. The minus sign issue was a legitimate failure of the test - it
doesn't make sense for a throughput ratio to be negative in this context. Before, the ratio
was calculated as the endsize divided by rate. The logging patch changes this to endsize -
startsize divided by rate. I've reverted this to the old behavior and removed the minus sign
from the regex.

The CCM change was needed - it broke some tests. We also need to continue to support old C*
versions in CCM, so I added back the ability to match the old format as well.

We have the same problem with the dtests - these will continue to be run against older, long-lived
branches without these changes, so I've made the i optional in the regex, so we can match
KiB or KB, for example.

I've restarted CI with these small fixes and also rebased the patch on latest trunk. Branches
for [cassandra|https://github.com/jkni/cassandra/tree/9692-trunk], [cassandra-dtest|https://github.com/jkni/cassandra-dtest/tree/9692-trunk-fix],
and [CCM|https://github.com/jkni/ccm/tree/CASS-9692-trunk-fix] are pushed - I made the small
fixes described above because I'd like to get this in before code freeze for 3.6 at the end
of the week.

> Print sensible units for all log messages
> -----------------------------------------
>
>                 Key: CASSANDRA-9692
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-9692
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Benedict
>            Assignee: Giampaolo
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.x
>
>         Attachments: Cassandra9692-Rev1-trunk-giampaolo-trapasso-at-radicalbit-io.diff,
Cassandra9692-Rev2-trunk-giampaolo.trapasso-at-radicalbit-io.diff, Cassandra9692-trunk-giampaolo-trapasso-at-radicalbit-io.diff,
ccm-bb08b6798f3fda39217f2daf710116a84a3ede84.patch, dtests-8a1017398ab55a4648fcc307a9be0644c02602dd.patch
>
>
> Like CASSANDRA-9691, this has bugged me too long. it also adversely impacts log analysis.
I've introduced some improvements to the bits I touched for CASSANDRA-9681, but we should
do this across the codebase. It's a small investment for a lot of long term clarity in the
logs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message